Skip to content

Add new API for calculate template hash#7046

Merged
raych1 merged 6 commits intoAzure:masterfrom
hjhhh3000vitae:hashApi
Aug 29, 2019
Merged

Add new API for calculate template hash#7046
raych1 merged 6 commits intoAzure:masterfrom
hjhhh3000vitae:hashApi

Conversation

@hjhhh3000vitae
Copy link
Copy Markdown
Contributor

@hjhhh3000vitae hjhhh3000vitae commented Aug 27, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation bot commented Aug 27, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 6c513c0, Iteration 9)

Warning .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
  • No packages generated.
Failed Python: test-repo-billy/azure-sdk-for-python [Logs]
  • No packages generated.
In-Progress Java: test-repo-billy/azure-sdk-for-java [Logs]
  • Package generation in progress.
In-Progress Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • Succeeded preview/resources/mgmt/2015-10-01-preview [Logs] [Instructions] [Generation PR] [Integration PR]
  • Warning preview/resources/mgmt/2016-09-01-preview [Logs]
  • Warning preview/resources/mgmt/2017-06-01-preview [Logs]
  • In-Progress resources/mgmt/2015-01-01 [Logs]
  • In-Progress resources/mgmt/2015-11-01 [Logs]
  • In-Progress resources/mgmt/2015-12-01 [Logs]
  • In-Progress resources/mgmt/2016-02-01 [Logs]
  • In-Progress resources/mgmt/2016-04-01 [Logs]
  • In-Progress resources/mgmt/2016-06-01 [Logs]
  • In-Progress resources/mgmt/2016-07-01 [Logs]
  • In-Progress resources/mgmt/2016-09-01 [Logs]
  • In-Progress resources/mgmt/2016-12-01 [Logs]
  • In-Progress resources/mgmt/2017-05-10 [Logs]
  • In-Progress resources/mgmt/2017-09-01 [Logs]
  • In-Progress resources/mgmt/2018-02-01 [Logs]
  • In-Progress resources/mgmt/2018-03-01 [Logs]
  • In-Progress resources/mgmt/2018-05-01 [Logs]
  • In-Progress resources/mgmt/2018-06-01 [Logs]
  • In-Progress resources/mgmt/2019-01-01 [Logs]
  • In-Progress resources/mgmt/2019-03-01 [Logs]
  • In-Progress resources/mgmt/2019-05-01 [Logs]
  • In-Progress resources/mgmt/2019-06-01 [Logs]
In-Progress JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@hjhhh3000vitae hjhhh3000vitae added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 27, 2019
@azuresdkci azuresdkci requested a review from raych1 August 27, 2019 07:10
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Aug 27, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5639

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Aug 27, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#6834

@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Aug 27, 2019

Can one of the admins verify this patch?

This was referenced Aug 27, 2019
Closed
Merged
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Aug 27, 2019
Closed
raych1
raych1 approved these changes Aug 27, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@raych1 raych1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@anthony-c-martin anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 28, 2019
@hjhhh3000vitae
Copy link
Copy Markdown
Contributor Author

hjhhh3000vitae commented Aug 28, 2019

@raych1 Since ARM has signed-off, could you please review this PR?

@anthony-c-martin
Copy link
Copy Markdown
Member

anthony-c-martin commented Aug 28, 2019

@hjhhh3000vitae heads-up - I just merged a new API version (2019-08-01) - you probably want to fetch the latest and also make your changes to this version. I'll block this PR just so it doesn't get accidentally merged.

anthony-c-martin
anthony-c-martin requested changes Aug 28, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just blocking this PR as @hjhhh3000vitae will most likely want to pick up the latest changes from master to avoid having to make a separate PR.

@raych1 raych1 merged commit 3fa20fb into Azure:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raych1 raych1 raych1 approved these changes

@anthony-c-martin anthony-c-martin anthony-c-martin approved these changes

@Tiano2017 Tiano2017 Awaiting requested review from Tiano2017

Assignees

@raych1 raych1

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hjhhh3000vitae @AutorestCI @azuresdkci @anthony-c-martin @raych1